c4patino/nixpkgs-review-gha
1
0
Fork 0
Code Issues Projects Releases Packages Wiki Activity

feat: don't be pedantic about sandbox setting when on linux

Browse source 
I often see `nixpkgs-review-gha` reports [like
this](https://github.com/NixOS/nixpkgs/pull/422189#issuecomment-3033579304).
Here, the `x86_64-linux (sandbox = true)` is completely redundant.
I removed it on my fork, but you might want this change as well.

(cherry-picked from 8274cbf710f7daefcc58851033e3ea22f93a0898)
This commit is contained in:
Tom van Dijk 2025-05-01 15:50:54 +02:00
commit 1c0a725a80
No known key found for this signature in database
GPG key ID: 7A984C8207ADBA51
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
.github/workflows/review.yml vendored
View file

@ -202,14 +202,18 @@ jobs:
- name: generate report - name: generate report
id: report id: report
env:
OS: ${{ runner.os }}
run: | run: |
if [[ -s fetch_cmd ]]; then if [[ -s fetch_cmd ]]; then
cat fetch_cmd cat fetch_cmd
echo fetch_cmd_${{ matrix.system }}=$(base64 -w0 fetch_cmd) >> "$GITHUB_OUTPUT" echo fetch_cmd_${{ matrix.system }}=$(base64 -w0 fetch_cmd) >> "$GITHUB_OUTPUT"
fi fi
dir=~/.cache/nixpkgs-review/pr-${PR_NUMBER} dir=~/.cache/nixpkgs-review/pr-${PR_NUMBER}
sandbox=$(nix config show sandbox) if [ "$OS" != "Linux" ]; then
sed -i '/^###/s/$/ (sandbox = '"$sandbox"')/' $dir/report.md sandbox=$(nix config show sandbox)
sed -i '/^###/s/$/ (sandbox = '"$sandbox"')/' "$dir/report.md"
fi
cat $dir/report.md cat $dir/report.md
report=$(jq -c '.+{$md}' $dir/report.json --rawfile md $dir/report.md | base64 -w0) report=$(jq -c '.+{$md}' $dir/report.json --rawfile md $dir/report.md | base64 -w0)
echo report_${{ matrix.system }}=$report >> "$GITHUB_OUTPUT" echo report_${{ matrix.system }}=$report >> "$GITHUB_OUTPUT"