c4patino/nixpkgs
1
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2026-07-06 17:13:24 -05:00
Code Issues Projects Releases Packages Wiki Activity

workflows/lint: fully skip the commits job in Merge Queues

Browse source 
Follow-up to 7cf5972410

While the JS script already returned early, we can save a few resources
by skipping the job entirely when there's no `pull_request` context.
This commit is contained in:
Matt Sturgeon 2025-12-18 13:09:17 +00:00
commit 7cfe9b8c85
No known key found for this signature in database
GPG key ID: 4F91844CED1A8299
2 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
.github/workflows/lint.yml vendored
View file

@ -126,6 +126,11 @@ jobs:
fi
commits:
# Only check commits if we have access to the pull_request context.
#
# Luckily there's no need to lint commit messages in the Merge Queue, because
# changes to the target branch can't change commit messages on the base branch.
if: ${{ github.event.pull_request.number }}
runs-on: ubuntu-slim
timeout-minutes: 5
steps:

3
ci/github-script/lint-commits.js
View file

@ -9,8 +9,7 @@ const { classify } = require('../supportedBranches.js')
* }} CheckCommitMessagesProps
*/
async function checkCommitMessages({ github, context, core }) {
// Do not run on merge groups: it'd be much harder, and there is no need
// (changes to the target branch can't change commit messages on the base branch).
// This check should only be run when we have the pull_request context.
const pull_number = context.payload.pull_request?.number
if (!pull_number) {
core.info('This is not a pull request. Skipping checks.')