From c874469f273138eeab6c3eadcb5b72c127afb6f7 Mon Sep 17 00:00:00 2001 From: Doron Behar Date: Thu, 7 May 2026 14:28:07 +0300 Subject: [PATCH 1/2] nixos/virtualisation.kvmgt: use newlines to separate sentences in docstrings --- nixos/modules/virtualisation/kvmgt.nix | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/nixos/modules/virtualisation/kvmgt.nix b/nixos/modules/virtualisation/kvmgt.nix index 5dfac60c1c69..f74036e35e1a 100644 --- a/nixos/modules/virtualisation/kvmgt.nix +++ b/nixos/modules/virtualisation/kvmgt.nix @@ -24,9 +24,10 @@ in options = { virtualisation.kvmgt = { enable = mkEnableOption '' - KVMGT (iGVT-g) VGPU support. Allows Qemu/KVM guests to share host's Intel integrated graphics card. - Currently only one graphical device can be shared. To allow users to access the device without root add them - to the kvm group: `users.extraUsers..extraGroups = [ "kvm" ];` + KVMGT (iGVT-g) VGPU support. + Allows Qemu/KVM guests to share host's Intel integrated graphics card. + Currently only one graphical device can be shared. + To allow users to access the device without root add them to the kvm group: `users.extraUsers..extraGroups = [ "kvm" ];` ''; # multi GPU support is under the question device = mkOption { @@ -38,8 +39,8 @@ in default = { }; type = with types; attrsOf (submodule [ { options = vgpuOptions; } ]); description = '' - Virtual GPUs to be used in Qemu. You can find devices via {command}`ls /sys/bus/pci/devices/*/mdev_supported_types` - and find info about device via {command}`cat /sys/bus/pci/devices/*/mdev_supported_types/i915-GVTg_V5_4/description` + Virtual GPUs to be used in Qemu. + You can find devices via {command}`ls /sys/bus/pci/devices/*/mdev_supported_types` and find info about device via {command}`cat /sys/bus/pci/devices/*/mdev_supported_types/i915-GVTg_V5_4/description` ''; example = { i915-GVTg_V5_8.uuid = [ "a297db4a-f4c2-11e6-90f6-d3b88d6c9525" ]; From 7c9a87f0176869d7dbb75f46170dc0943629a944 Mon Sep 17 00:00:00 2001 From: Doron Behar Date: Thu, 7 May 2026 14:28:52 +0300 Subject: [PATCH 2/2] nixos/virtualisation.kvmgt: explain explicitly it is meant for host Fix #516891. --- nixos/modules/virtualisation/kvmgt.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/nixos/modules/virtualisation/kvmgt.nix b/nixos/modules/virtualisation/kvmgt.nix index f74036e35e1a..1c78e16d9256 100644 --- a/nixos/modules/virtualisation/kvmgt.nix +++ b/nixos/modules/virtualisation/kvmgt.nix @@ -25,9 +25,9 @@ in virtualisation.kvmgt = { enable = mkEnableOption '' KVMGT (iGVT-g) VGPU support. - Allows Qemu/KVM guests to share host's Intel integrated graphics card. + When enabled on a host, allows Qemu/KVM guests to share host's Intel integrated graphics card. Currently only one graphical device can be shared. - To allow users to access the device without root add them to the kvm group: `users.extraUsers..extraGroups = [ "kvm" ];` + To allow host users to access the device without root add them to the kvm group: `users.extraUsers..extraGroups = [ "kvm" ];` ''; # multi GPU support is under the question device = mkOption { @@ -39,7 +39,7 @@ in default = { }; type = with types; attrsOf (submodule [ { options = vgpuOptions; } ]); description = '' - Virtual GPUs to be used in Qemu. + Virtual GPUs of the host to be used in Qemu. You can find devices via {command}`ls /sys/bus/pci/devices/*/mdev_supported_types` and find info about device via {command}`cat /sys/bus/pci/devices/*/mdev_supported_types/i915-GVTg_V5_4/description` ''; example = {