From b4113461331edbdef89fc8b591deb354385c0a90 Mon Sep 17 00:00:00 2001 From: r-vdp Date: Sat, 28 Mar 2026 10:47:37 +0100 Subject: [PATCH] nixos/tests/fish: fix test broken by coreutils 9.10 coreutils 9.10 man pages are generated by help2man 1.50 which embeds tty hyperlink escape codes (\X'tty: link ...'). These break fish's create_manpage_completions.py parser, so coreutils.fish is no longer generated. Switch to coreutils-full (the minimal coreutils has no man pages at all) and check for chmod.fish which still parses successfully. --- nixos/tests/fish.nix | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/nixos/tests/fish.nix b/nixos/tests/fish.nix index a134bf1f68c1..65ea0b964694 100644 --- a/nixos/tests/fish.nix +++ b/nixos/tests/fish.nix @@ -7,7 +7,9 @@ { programs.fish.enable = true; environment.systemPackages = with pkgs; [ - coreutils + # coreutils-full (not coreutils) so that man pages are available + # for completion generation + coreutils-full procps # kill collides with coreutils' to test https://github.com/NixOS/nixpkgs/issues/56432 ]; @@ -19,7 +21,7 @@ #python '' start_all() - machine.wait_for_file("/etc/fish/generated_completions/coreutils.fish") + machine.wait_for_file("/etc/fish/generated_completions/chmod.fish") machine.wait_for_file("/etc/fish/generated_completions/kill.fish") machine.succeed( "fish -ic 'echo $fish_complete_path' | grep -q '/share/fish/vendor_completions.d /etc/fish/generated_completions /root/.cache/fish/generated_completions$'"