ultrastar-creator: 2019-04-23 -> 1.3.1 (#513789)

maintainers/maintainer-list.nix

@@ -18493,6 +18493,11 @@
     githubId = 3579600;
     name = "Jacob Moody";
   };
+  mooses = {
+    name = "Remu Salminen";
+    github = "RemuSalminen";
+    githubId = 85031022;
+  };
   moosingin3space = {
     email = "moosingin3space@gmail.com";
     github = "moosingin3space";

pkgs/tools/misc/ultrastar-creator/default.nix

@@ -2,64 +2,108 @@
   lib,
   stdenv,
   fetchFromGitHub,
-  qmake,
+  qt6,
-  qtbase,
   pkg-config,
-  wrapQtAppsHook,
   taglib,
+  alsa-lib,
+  pulseaudio,
+  cld2,
   libbass,
   libbass_fx,
+  makeDesktopItem,
 }:
 
-# TODO: get rid of (unfree) libbass
+stdenv.mkDerivation (finalAttrs: {
-# issue:https://github.com/UltraStar-Deluxe/UltraStar-Creator/issues/3
-# there’s a WIP branch here:
-# https://github.com/UltraStar-Deluxe/UltraStar-Creator/commits/BASS_removed
-
-stdenv.mkDerivation {
   pname = "ultrastar-creator";
-  version = "2019-04-23";
+  version = "1.3.1";
 
   src = fetchFromGitHub {
     owner = "UltraStar-Deluxe";
     repo = "UltraStar-Creator";
-    rev = "36583b4e482b68f6aa949e77ef2744776aa587b1";
+    tag = finalAttrs.version;
-    sha256 = "1rzz04l7s7pxj74xam0cxlq569lfpgig35kpbsplq531d4007pc9";
+    hash = "sha256-QWlgMpyNadRh6Tkg1mAtb11mKbk4thE6sCQKiDyR/SA=";
   };
 
   postPatch = ''
-    # we don’t want prebuilt binaries checked into version control!
+    rm -rf lib include/bass include/bass_fx include/cld2
-    rm -rf lib include
+
-    sed -e "s|DESTDIR =.*$|DESTDIR = $out/bin|" \
+    echo 'const char *revision = "${finalAttrs.version}"; const char *date_time = "unknown";' \
-        -e 's|-L".*unix"||' \
+      > src/version.h
-        -e "/QMAKE_POST_LINK/d" \
+
-        -e "s|../include/bass|${lib.getLib libbass}/include|g" \
+    substituteInPlace src/UltraStar-Creator.pro \
-        -e "s|../include/bass_fx|${lib.getLib libbass_fx}/include|g" \
+      --replace-fail 'DESTDIR = ../bin/release' "DESTDIR = $out/bin" \
-        -e "s|../include/taglib|${lib.getLib taglib}/include|g" \
+      --replace-fail 'DESTDIR = ../bin/debug'   "DESTDIR = $out/bin" \
-        -i src/UltraStar-Creator.pro
+      --replace-fail '../include/bass_fx'        '${lib.getLib libbass_fx}/include' \
+      --replace-fail '../include/bass'           '${lib.getLib libbass}/include' \
+      --replace-fail '../include/cld2/public'    '${cld2}/include/cld2/public' \
+      --replace-fail '../include/taglib'         '${lib.getDev taglib}/include'
+
+    sed -i \
+      -e 's|-L"../lib/unix"||' \
+      -e 's|-L"/usr/lib/x86_64-linux-gnu"||' \
+      -e '/QMAKE_POST_LINK/d' \
+      src/UltraStar-Creator.pro
+
+    sed -i \
+      -e '/QMAKE_EXTRA_TARGETS.*revtarget/d' \
+      -e '/PRE_TARGETDEPS.*version\.h/d' \
+      -e '/^revtarget\.target/d' \
+      -e '/^\trevtarget\./d' \
+      -e '/^revtarget\.depends/,/[^\\]$/d' \
+      src/UltraStar-Creator.pro
   '';
 
   preConfigure = ''
     cd src
   '';
 
-  nativeBuildInputs = [
+  qtWrapperArgs = [
-    qmake
+    "--prefix LD_LIBRARY_PATH : ${
-    pkg-config
+      lib.makeLibraryPath [
-    wrapQtAppsHook
+        alsa-lib
+        pulseaudio
+      ]
+    }"
   ];
+
+  nativeBuildInputs = [
+    pkg-config
+    qt6.qmake
+    qt6.wrapQtAppsHook
+  ];
+
   buildInputs = [
-    qtbase
+    cld2
-    taglib
     libbass
     libbass_fx
+    qt6.qtbase
+    taglib
+    alsa-lib
+    pulseaudio
   ];
 
+  installPhase = ''
+    runHook preInstall
+
+    install -Dm644 ../setup/unix/UltraStar-Creator.png $out/share/icons/hicolor/128x128/apps/ultrastar-creator.png
+    ln -s "$desktopItem/share/applications" "$out/share/"
+
+    runHook postInstall
+  '';
+
+  desktopItem = makeDesktopItem {
+    name = finalAttrs.pname;
+    desktopName = "UltraStar-Creator";
+    exec = "UltraStar-Creator";
+    icon = "ultrastar-creator";
+  };
+
   meta = {
     mainProgram = "UltraStar-Creator";
     description = "Ultrastar karaoke song creation tool";
     homepage = "https://github.com/UltraStar-Deluxe/UltraStar-Creator";
     license = lib.licenses.gpl2Only;
-    maintainers = [ ];
+    maintainers = with lib.maintainers; [ mooses ];
+    platforms = lib.platforms.linux;
   };
-}
+})

pkgs/top-level/all-packages.nix

@@ -10518,7 +10518,7 @@ with pkgs;
     ];
   };
 
-  ultrastar-creator = libsForQt5.callPackage ../tools/misc/ultrastar-creator { };
+  ultrastar-creator = callPackage ../tools/misc/ultrastar-creator { };
 
   ultrastar-manager = libsForQt5.callPackage ../tools/misc/ultrastar-manager { };