c4patino/qoverflow
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed vote implementation for new response

Browse source
This commit is contained in:
Ceferino Patino 2022-08-02 14:39:15 -05:00
commit a50298183e
4 changed files with 61 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

4
server/routes/question/EditAnswerCommentVote.js
View file

@ -30,9 +30,9 @@ async function EditAnswerCommentVote(req, res) {
});
if (!cachedVote) {
const { success, vote } = await createRequest('get', URL);
const { error, vote } = await createRequest('get', URL);
cachedVote = success ? { status: vote } : { status: null };
cachedVote = !error ? { status: vote } : { status: null };
}
if (cachedVote.status === 'upvoted') {

11
server/routes/question/EditAnswerVote.js
View file

@ -26,8 +26,11 @@ async function EditAnswerVote(req, res) {
// Get cached vote and answer, refresh cache if not present
let cachedAnswer;
try { cachedAnswer = await Answer.findById(answer_id); }
catch { return res.status(400).send(config.errorNotFound); }
try {
cachedAnswer = await Answer.findById(answer_id);
} catch {
return res.status(400).send(config.errorNotFound);
}
let cachedVote = await Vote.findOneAndDelete({
parent_id: answer_id,
@ -35,9 +38,9 @@ async function EditAnswerVote(req, res) {
});
if (!cachedVote) {
const { success, vote } = await createRequest('get', URL);
const { error, vote } = await createRequest('get', URL);
cachedVote = success ? { status: vote } : { status: null };
cachedVote = !error ? { status: vote } : { status: null };
}
if (cachedVote.status === 'upvoted') {

4
server/routes/question/EditCommentVote.js
View file

@ -27,9 +27,9 @@ async function EditAnswerVote(req, res) {
});
if (!cachedVote) {
const { success, vote } = await createRequest('get', URL);
const { error, vote } = await createRequest('get', URL);
cachedVote = success ? { status: vote } : { status: null };
cachedVote = !error ? { status: vote } : { status: null };
}
if (cachedVote.status === 'upvoted') {

78
server/routes/question/EditQuestionVote.js
View file

@ -20,10 +20,14 @@ async function downvote(res, user) {
});
}
{
const { success } = await createRequest('patch', `/users/${user.username}/points`, {
operation: 'decrement',
amount: 1,
});
const { success } = await createRequest(
'patch',
`/users/${user.username}/points`,
{
operation: 'decrement',
amount: 1,
}
);
if (!success) return res.status(500).send(config.errorGeneric);
await User.findByIdAndUpdate(user.id, { $inc: { points: -1 } });
}
@ -44,7 +48,6 @@ async function upvote(res, user) {
}
async function EditQuestionVote(req, res) {
const { user } = req;
const { question_id } = req.params;
const { operation } = req.body;
@ -70,9 +73,8 @@ async function EditQuestionVote(req, res) {
});
if (!cachedVote) {
const { success, vote } = await createRequest('get', URL);
if (!success) return res.status(500).send(config.errorGeneric);
cachedVote = vote ?? null;
const { error, vote } = await createRequest('get', URL);
cachedVote = !error ? { status: vote } : { status: null };
}
if (cachedVote === 'upvoted') {
@ -119,26 +121,38 @@ async function EditQuestionVote(req, res) {
if (operation === 'upvote') {
await upvote(res, user);
{
const { success } = await createRequest('patch', `/users/${question.creator}/points`, {
operation: 'increment',
amount: 6,
});
const { success } = await createRequest(
'patch',
`/users/${question.creator}/points`,
{
operation: 'increment',
amount: 6,
}
);
if (!success) return res.status(500).send(config.errorGeneric);
}
return res.send({ vote: 'upvoted' });
} else {
{
const { success } = await createRequest('patch', `/users/${question.creator}/points`, {
operation: 'increment',
amount: 1,
});
const { success } = await createRequest(
'patch',
`/users/${question.creator}/points`,
{
operation: 'increment',
amount: 1,
}
);
if (!success) return res.status(500).send(config.errorGeneric);
}
{
const { success } = await createRequest('patch', `/users/${user.username}/points`, {
operation: 'increment',
amount: 1,
});
const { success } = await createRequest(
'patch',
`/users/${user.username}/points`,
{
operation: 'increment',
amount: 1,
}
);
if (!success) return res.status(500).send(config.errorGeneric);
await User.findByIdAndUpdate(user.id, { $inc: { points: 1 } });
}
@ -147,20 +161,28 @@ async function EditQuestionVote(req, res) {
if (operation === 'upvote') {
await upvote(res, user);
{
const { success } = await createRequest('patch', `/users/${question.creator}/points`, {
operation: 'increment',
amount: 5,
});
const { success } = await createRequest(
'patch',
`/users/${question.creator}/points`,
{
operation: 'increment',
amount: 5,
}
);
if (!success) return res.status(500).send(config.errorGeneric);
}
return res.send({ vote: 'upvoted' });
} else if (operation === 'downvote') {
await downvote(res, user);
{
const { success } = await createRequest('patch', `/users/${question.creator}/points`, {
operation: 'decrement',
amount: 1,
});
const { success } = await createRequest(
'patch',
`/users/${question.creator}/points`,
{
operation: 'decrement',
amount: 1,
}
);
if (!success) return res.status(500).send(config.errorGeneric);
}
return res.send({ vote: 'downvoted' });